Re: pgsql: Fix search_path to a safe value during maintenance operations. - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: pgsql: Fix search_path to a safe value during maintenance operations.
Date
Msg-id 20230706172004.GA3635686@nathanxps13
Whole thread Raw
In response to Re: pgsql: Fix search_path to a safe value during maintenance operations.  (Jeff Davis <pgsql@j-davis.com>)
Responses Re: pgsql: Fix search_path to a safe value during maintenance operations.
List pgsql-hackers
On Thu, Jul 06, 2023 at 12:55:14AM -0700, Jeff Davis wrote:
> It was difficult to review standalone, so I tried a quick version
> myself and ended up with very similar results.

Thanks for taking a look.

> The only substantial
> difference was that I put back:
> 
> 
> +               if (!vacuum_is_relation_owner(relid, classForm,
> options))
> +                       continue;
> 
> 
> in get_all_vacuum_rels() whereas your patch left it out -- double-check
> that we're doing the right thing there.

The privilege check was moved in d46a979, which I think still makes sense,
so I left it there.  That might be why it looks like I removed it.

> Also remember to bump the catversion. Other than that, it looks good to
> me.

Will do.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Gurjeet Singh
Date:
Subject: Re: MERGE ... RETURNING
Next
From: Andres Freund
Date:
Subject: Re: Avoid overflow with simplehash