Re: Making background psql nicer to use in tap tests - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Making background psql nicer to use in tap tests
Date
Msg-id 20230408005733.rlzh55eh5beq6kfn@awork3.anarazel.de
Whole thread Raw
In response to Re: Making background psql nicer to use in tap tests  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Making background psql nicer to use in tap tests
List pgsql-hackers
Hi,

On 2023-04-07 20:49:39 -0400, Tom Lane wrote:
> I wrote:
> > I've been doing some checking with perlbrew locally.  It appears to not
> > be about IO::Pty so much as IPC::Run: it works with IPC::Run 0.99 but
> > not 0.79.  Still bisecting to identify exactly what's the minimum
> > okay version.
> 
> The answer is: it works with IPC::Run >= 0.98.  The version of IO::Pty
> doesn't appear significant; it works at least back to 1.00 from early
> 2002.
> 
> IPC::Run 0.98 is relatively new (2018), so I don't think it'd fly
> to make that our new minimum version across-the-board.  I recommend
> just setting up this one test to SKIP if IPC::Run is too old.

Does the test actually take a while before it fails, or is it quick? It's
possible the failure is caused by 001_password.pl's use of
set_query_timer_restart(). I don't think other tests do something quite
comparable.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Making background psql nicer to use in tap tests
Next
From: Tom Lane
Date:
Subject: Re: Making background psql nicer to use in tap tests