Re: Improve WALRead() to suck data directly from WAL buffers when possible - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Improve WALRead() to suck data directly from WAL buffers when possible
Date
Msg-id 20230228004452.GA1391969@nathanxps13
Whole thread Raw
In response to Re: Improve WALRead() to suck data directly from WAL buffers when possible  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: Improve WALRead() to suck data directly from WAL buffers when possible
List pgsql-hackers
On Wed, Feb 08, 2023 at 08:00:00PM +0530, Bharath Rupireddy wrote:
> +            /*
> +             * We read some of the requested bytes. Continue to read remaining
> +             * bytes.
> +             */
> +            ptr += nread;
> +            nbytes -= nread;
> +            dst += nread;
> +            *read_bytes += nread;

Why do we only read a page at a time in XLogReadFromBuffersGuts()?  What is
preventing us from copying all the data we need in one go?

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Non-superuser subscription owners
Next
From: Peter Smith
Date:
Subject: Re: Rework LogicalOutputPluginWriterUpdateProgress