Re: Change xl_hash_vacuum_one_page.ntuples from int to uint16 - Mailing list pgsql-hackers

On Sat, Jan 21, 2023 at 06:42:08AM +0100, Drouvot, Bertrand wrote:
> On 1/20/23 9:01 PM, Nathan Bossart wrote:
>> Should we also change the related
>> variables (e.g., ndeletable in _hash_vacuum_one_page()) to uint16?
> 
> Yeah, I thought about it too. What I saw is that there is other places that would be good candidates for the same
> kind of changes (see the int ntodelete argument in gistXLogDelete() being assigned to gistxlogDelete.ntodelete
(uint16)for example).
 
> 
> So, what do you think about:
> 
> 1) keep this patch as it is (to "only" address the struct field and avoid possible future "useless" padding size
increase)
> and
> 2) create a new patch (once this one is committed) to align the types for variables/arguments with the structs
(relatedto XLOG records) fields when they are not?
 

Okay.  I've marked this one as ready-for-committer, then.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com