Re: BUG #17753: pg_dump --if-exists bug - Mailing list pgsql-bugs

From Noah Misch
Subject Re: BUG #17753: pg_dump --if-exists bug
Date
Msg-id 20230121160012.GC1356297@rfd.leadboat.com
Whole thread Raw
In response to Re: BUG #17753: pg_dump --if-exists bug  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
On Thu, Jan 19, 2023 at 07:09:50PM -0500, Tom Lane wrote:
> I wrote:
> > I think we need to do the attached, more or less.  Also, although the
> > given case seems to be new, we'd probably better back-patch, because
> > I'm not convinced that there aren't other ways to reach this.
> 
> Ah --- we only need to back-patch to v15, because this business of
> possibly having a comment in the dropStmt is new in a7a7be1f2.
> That commit also added the existing exceptions for comments in
> pg_backup_archiver.c ... but it missed the need to have special
> cases for dropStmts too.

Your commit 74739d1 looks good.  Thanks.



pgsql-bugs by date:

Previous
From: Amit Kapila
Date:
Subject: Re: DROP DATABASE deadlocks with logical replication worker in PG 15.1
Next
From: Tomas Vondra
Date:
Subject: Re: BUG #17757: Not honoring huge_pages setting during initdb causes DB crash in Kubernetes