Re: pgsql: Fix typos and bump catversion. - Mailing list pgsql-hackers

Hi,

On 2022-11-19 17:10:57 -0500, Joe Conway wrote:
> Rishu Bagga pointed out to me offlist that this catversion bump seems
> flawed:
> 
> diff --git a/src/include/catalog/catversion.h
> b/src/include/catalog/catversion.h
> index c6ef593207c227ce10b0c897379476b553974f67..b3a57136b755fed182b4518330e65786032db870
> 100644 (file)
> --- a/src/include/catalog/catversion.h
> +++ b/src/include/catalog/catversion.h
> @@ -57,6 +57,6 @@
>   */
> 
>  /*                         yyyymmddN */
> -#define CATALOG_VERSION_NO 202211121
> +#define CATALOG_VERSION_NO 202211821
> 
>  #endif
> 
> I think that should be 202211181, no? I am not clear on the desirable way to
> fix though :-/

I think it's fine to just update to a "normal" catversion. We really just
match for an exact match with a few exceptions (somewhere in pg_upgrade IIRC),
and those exceptions don't really matter for some individual commit on the
development branch.

Greetings,

Andres Freund