Re: MERGE regress test - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: MERGE regress test
Date
Msg-id 20221116173714.icptpfguyua2wucq@alvherre.pgsql
Whole thread Raw
In response to MERGE regress test  (Teja Mupparti <Tejeswar.Mupparti@microsoft.com>)
Responses Re: MERGE regress test
List pgsql-hackers
On 2022-Nov-16, Teja Mupparti wrote:

> A quick question on merge regress-test
> 
> https://github.com/postgres/postgres/blob/REL_15_STABLE/src/test/regress/expected/merge.out#L846
j 
> should there be an ERROR or comment needs a fix? What's the expected behavior?

Hmm, good find.  As I recall, I was opposed to the idea of throwing an
error if the WHEN expression writes to the database, and the previous
implementation had some hole, so I just ripped it out after discussing
it; but I evidently failed to notice this test case about it.

However, I can't find any mailing list discussion about this point.
Maybe I just asked Simon off-list about it.

IMO just deleting that test is a sufficient fix.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
Tom: There seems to be something broken here.
Teodor: I'm in sackcloth and ashes...  Fixed.
        http://archives.postgresql.org/message-id/482D1632.8010507@sigaev.ru



pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: [PoC] Let libpq reject unexpected authentication requests
Next
From: Tom Lane
Date:
Subject: Re: Make a 100_bugs.pl test more faster.