Hi,
On 2022-11-14 17:16:46 -0600, Justin Pryzby wrote:
> On Sun, Aug 28, 2022 at 01:37:41PM -0700, Andres Freund wrote:
> > > You're running tap tests via a python script. There's no problem with
> > > that, but it's different from what's done by the existing makefiles.
> > > I was able to remove the python indirection - maybe that's better to
> > > talk about on the CI thread? That moves some setup for TAP tests
> > > (TESTDIR, PATH, cd) from Makefile into the existing perl, which means
> > > less duplication.
> >
> > I'm doubtful it's worth removing. You'd need to move removing the files from
> > the last run into both pg_regress and the tap test infrastructure. And I do
> > think it's nice to afterwards have markers which tests failed, so we can only
> > collect their logs.
>
> Are you planning on putting something in place to remove (or allow
> removing) logs for successful tests ? Is that primarily for cirrus, or
> buildfarm or ??
What I'd like to do is to add a 'collect-logs-for-failed-test's script and/or
target that moves those logs into a different folder. By default we'd then
collect all the files from that different folder in CI. I think that's better
than removing logs for successful tests.
I'd like to use the same script for the BF as well - we've had too many cases
where we had to adjust things in multiple places / code-bases.
Perhaps we could also use that test to print the list of relevant logfiles at
the end of a "local" testrun?
> It is wasteful to upload thousdands of logfiles to show a single
> failure. That would make our cirrus tasks faster - compressing and
> uploading the logs takes over a minute.
>
> It's also a lot friendlier to show fewer than 8 pages of test folders to
> search through to find the one that failed.
Indeed.
Greetings,
Andres Freund
