Re: shadow variables - pg15 edition - Mailing list pgsql-hackers

From Andres Freund
Subject Re: shadow variables - pg15 edition
Date
Msg-id 20221010164549.7e5v6vvmcdtxuvov@awork3.anarazel.de
Whole thread Raw
In response to Re: shadow variables - pg15 edition  (Andres Freund <andres@anarazel.de>)
Responses Re: shadow variables - pg15 edition  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
On 2022-10-10 09:37:38 -0700, Andres Freund wrote:
> On 2022-10-10 18:33:11 +0200, Alvaro Herrera wrote:
> > On 2022-Oct-10, Andres Freund wrote:
> > 
> > > Given the age of affected perl instances I suspect there'll not be a lot of
> > > developers affected, and the number of warnings is reasonably small too. It'd
> > > likely hurt more developers to not see the warnings locally, given that such
> > > shadowing often causes bugs.
> > 
> > Maybe we can install a filter-out in src/pl/plperl's Makefile for the
> > time being.
> 
> We could, but is it really a useful thing for something fixed 6 years ago?

As an out, a hypothetical dev could add -Wno-shadow=compatible-local to their
CFLAGS.



pgsql-hackers by date:

Previous
From: "Imseih (AWS), Sami"
Date:
Subject: Re: Add index scan progress to pg_stat_progress_vacuum
Next
From: Alvaro Herrera
Date:
Subject: Re: shadow variables - pg15 edition