Re: Simplifying our Trap/Assert infrastructure - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Simplifying our Trap/Assert infrastructure
Date
Msg-id 20221009212937.GC900071@nathanxps13
Whole thread Raw
In response to Re: Simplifying our Trap/Assert infrastructure  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Simplifying our Trap/Assert infrastructure  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sun, Oct 09, 2022 at 05:08:39PM -0400, Tom Lane wrote:
> Something I thought about but forgot to mention in the initial email:
> is it worth sprinkling these macros with "unlikely()"?  I think that
> compilers might assume the right thing automatically based on noticing
> that ExceptionalCondition is noreturn ... but then again they might
> not.  Of course we're not that fussed about micro-optimizations in
> assert-enabled builds; but with so many Asserts in the system, it
> might still add up to something noticeable if there is an effect.

I don't see why not.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: use has_privs_of_role() for pg_hba.conf
Next
From: Nathan Bossart
Date:
Subject: Re: Switching XLog source from archive to streaming when primary available