Re: Avoid use deprecated Windows Memory API - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Avoid use deprecated Windows Memory API
Date
Msg-id 20220915125029.ntzqn63636fio7lc@alvherre.pgsql
Whole thread Raw
In response to Avoid use deprecated Windows Memory API  (Ranier Vilela <ranier.vf@gmail.com>)
Responses Re: Avoid use deprecated Windows Memory API
Re: Avoid use deprecated Windows Memory API
List pgsql-hackers
On 2022-Sep-14, Ranier Vilela wrote:

> According to:
> https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-localalloc

> LocalAlloc is deprecated.
> So use HeapAlloc instead, once LocalAlloc is an overhead wrapper to
> HeapAlloc.

These functions you are patching are not in performance-sensitive code,
so I doubt this makes any difference performance wise.  I doubt
Microsoft will ever remove these deprecated functions, given its history
of backwards compatibility, so from that perspective this change does
not achieve anything either.

If you were proposing to change how palloc() allocates memory, that
would be quite different and perhaps useful, as long as a benchmark
accompanies the patch.
.
-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/



pgsql-hackers by date:

Previous
From: Ajin Cherian
Date:
Subject: Re: Support logical replication of DDLs
Next
From: "kuroda.hayato@fujitsu.com"
Date:
Subject: RE: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher