Re: Functions 'is_publishable_class' and 'is_publishable_relation' should stay together. - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Functions 'is_publishable_class' and 'is_publishable_relation' should stay together.
Date
Msg-id 20220729095900.kemsantarx4klz5r@alvherre.pgsql
Whole thread Raw
In response to Re: Functions 'is_publishable_class' and 'is_publishable_relation' should stay together.  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: Functions 'is_publishable_class' and 'is_publishable_relation' should stay together.
List pgsql-hackers
On 2022-Jul-29, Peter Smith wrote:

> On Fri, Jul 29, 2022 at 7:36 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> >
> > I don't object to doing this, but I think these two functions should
> > stay together nonetheless.
> 
> If you believe there is still a problem after applying the patch
> please explicitly name what function(s) you think should be moved.

Well, I checked the commit and the functions I was talking about look OK
now.  However, looking again, pg_relation_is_publishable is in the wrong
place (should be right below is_publishable_relaton), and I wonder why
aren't get_publication_oid and get_publication_name in lsyscache.c.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/



pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: Functions 'is_publishable_class' and 'is_publishable_relation' should stay together.
Next
From: Amit Kapila
Date:
Subject: Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication