Re: pgsql: Add copy/equal support for XID lists - Mailing list pgsql-committers

From Alvaro Herrera
Subject Re: pgsql: Add copy/equal support for XID lists
Date
Msg-id 20220712183516.cmdowamk7eqahmjw@alvherre.pgsql
Whole thread Raw
In response to Re: pgsql: Add copy/equal support for XID lists  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On 2022-Jul-12, Tom Lane wrote:

> What about outfuncs/readfuncs?  I see that you fixed _outList,
> but not its caller outNode:
> 
>     else if (IsA(obj, List) || IsA(obj, IntList) || IsA(obj, OidList))
>         _outList(str, obj);
> 
> and the LEFT_PAREN case in nodeRead() doesn't know what to do either.

Hmm, true -- naively grepping for OidList wasn't enough (moreso when I
failed to notice one occurrence).  This patch closes the holes you
mentioned.  I haven't found any others yet.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"La vida es para el que se aventura"

Attachment

pgsql-committers by date:

Previous
From: Larry Rosenman
Date:
Subject: Re: pgsql: Fix out-of-bounds read in json_lex_string
Next
From: Tom Lane
Date:
Subject: pgsql: Remove trailing newlines in pg_upgrade's message strings.