Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Add copy/equal support for XID lists - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Add copy/equal support for XID lists
Date
Msg-id 1548311.1657636605@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Add copy/equal support for XID lists  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: pgsql: Add copy/equal support for XID lists
List pgsql-committers
Tree view 
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Add copy/equal support for XID lists

What about outfuncs/readfuncs?  I see that you fixed _outList,
but not its caller outNode:

    else if (IsA(obj, List) || IsA(obj, IntList) || IsA(obj, OidList))
        _outList(str, obj);

and the LEFT_PAREN case in nodeRead() doesn't know what to do either.

            regards, tom lane

pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Rename some functions to mention Relation instead of RelFileLoca
Next
From: Tom Lane
Date:
Subject: pgsql: Add defenses against unexpected changes in the NodeTag enum list