Hi,
The cfbot says that the patch doesn't apply anymore, so here's a v3 with the
changes mentioned below.
On Tue, Mar 01, 2022 at 05:19:50PM +0800, Julien Rouhaud wrote:
>
> If you prefer to interleave static and non static function I can change it.
Change the split to not reorder functions.
> > +#include "utils/guc.h"
> > +//#include "utils/tuplestore.h"
>
> Yes I noticed this one this morning. I didn't want to send a new patch version
> just for that, but I already fixed it locally.
Included.
> Yes I'm aware of that thread. I will be happy to change the patch to use
> MakeFuncResultTuplestore() as soon as it lands. Thanks for the notice though.
Done, with the new SetSingleFuncCall().
> > It could be possible to do installcheck on an instance that has user
> > mappings meaning that this had better be ">= 0", no?
>
> I thought about it, and supposed it would bring a bit more value with the test
> like that. I can change it if you prefer.
Change this way.
