Re: definition of CalculateMaxmumSafeLSN - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: definition of CalculateMaxmumSafeLSN
Date
Msg-id 20220301044440.xh36kcm544vhy3dh@jrouhaud
Whole thread Raw
In response to Re: definition of CalculateMaxmumSafeLSN  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-hackers
Hi,

On Tue, Mar 01, 2022 at 10:11:03AM +0900, Kyotaro Horiguchi wrote:
> At Mon, 28 Feb 2022 17:01:10 +0300, Sergei Kornilov <sk@zsrv.org> wrote in 
> > Hello
> > I just spotted in src/include/access/xlog.h:
> > extern XLogRecPtr CalculateMaxmumSafeLSN(void);
> > 
> > This function doesn't seem to be used anywhere or even defined? "git grep CalculateMaxmumSafeLSN" shows only this
line.
> > Was added in c6550776394e25c1620bc8258427c8f1d448080d "Allow users to limit storage reserved by replication slots"
> 
> Hmm.  I think I remember of that name. You're right, it is a function
> that was once added during development of the commit but eventually
> gone.
> 
> So it should be removed.

+1.  I'm Ccing Álvaro as he's the committer.



pgsql-hackers by date:

Previous
From: Paul Jungwirth
Date:
Subject: Re: range_agg with multirange inputs
Next
From: Pavel Stehule
Date:
Subject: Re: Schema variables - new implementation for Postgres 15