Re: Expose JIT counters/timing in pg_stat_statements - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: Expose JIT counters/timing in pg_stat_statements
Date
Msg-id 20220225133322.ekhgqbf2r34isa73@jrouhaud
Whole thread Raw
In response to Expose JIT counters/timing in pg_stat_statements  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Expose JIT counters/timing in pg_stat_statements  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Hi,

On Fri, Feb 25, 2022 at 02:06:29PM +0100, Magnus Hagander wrote:
> Here's a patch to add the sum of timings for JIT counters to
> pg_stat_statements, as a way to follow-up on if JIT is doing a good or
> a bad job in a configuration.

+1, it seems like something quite useful.

> I decided to only store the total time for the timings, since there
> are 4 different timings and storing max/min/etc for each one of them
> would lead to a bit too much data. This can of course be reconsidered,
> but I think that's a reasonable tradeoff.

I think the cumulated total time is enough.  Looking at the patch, I think we
should also cumulate the number of time jit was triggered, and
probably the same for each other main operation (optimization and inlining).
Otherwise the values may be wrong and look artificially low.



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: convert libpq uri-regress tests to tap test
Next
From: Bharath Rupireddy
Date:
Subject: Re: [PATCH] add relation and block-level filtering to pg_waldump