Re: pg_upgrade verbosity when redirecting output to log file - Mailing list pgsql-hackers

From Andres Freund
Subject Re: pg_upgrade verbosity when redirecting output to log file
Date
Msg-id 20220221010725.ft4qaialjyxpmivm@alap3.anarazel.de
Whole thread Raw
In response to Re: pg_upgrade verbosity when redirecting output to log file  (Justin Pryzby <pryzby@telsasoft.com>)
Responses Re: pg_upgrade verbosity when redirecting output to log file  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
Hi,

On 2022-02-18 19:46:26 -0600, Justin Pryzby wrote:
> +        * If outputting to a tty / or , append newline. pg_log_v() will put the
> +        * individual progress items onto the next line.
> +        */
> +       if (log_opts.isatty || log_opts.verbose)
>
> I guess the comment should say "or in verbose mode".

Indeed. I think I got caught in a back-and-forth between different
formulations.

Baring that, anybody against committing this?

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgsql: Add support for building with ZSTD.
Next
From: Michael Paquier
Date:
Subject: Re: Uniforms the errors msgs at tuplestore paths