On Wed, Feb 16, 2022 at 01:00:53PM -0800, Nathan Bossart wrote:
> On Wed, Feb 16, 2022 at 11:27:31AM -0800, Andres Freund wrote:
>> That doesn't strike me as great architecturally. E.g. in theory the same
>> problem could exist in single user mode. I think it doesn't today, because
>> RegisterSyncRequest() will effectively "absorb" it immediately, but that kind
>> of feels like an implementation detail?
>
> Yeah, maybe that is a reason to add an absorb somewhere within
> CreateCheckPoint() instead, like v1 [0] does. Then the extra absorb would
> be sufficient for single-user mode if the requests were not absorbed
> immediately.
Here is a new patch. This is essentially the same as v1, but I've spruced
up the comments and the commit message.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com