Re: Fix overflow in justify_interval related functions - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Fix overflow in justify_interval related functions
Date
Msg-id 20220214183540.GA2000855@nathanxps13
Whole thread Raw
In response to Fix overflow in justify_interval related functions  (Joseph Koshakow <koshy44@gmail.com>)
Responses Re: Fix overflow in justify_interval related functions  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sun, Feb 13, 2022 at 01:28:38PM -0500, Joseph Koshakow wrote:
> +SELECT justify_hours(interval '2147483647 days 24 hrs');
> +ERROR:  interval out of range

The docs [0] claim that the maximum value for interval is 178 million
years, but this test case is only ~6 million.  Should we instead rework the
logic to avoid overflow for this case?

[0] https://www.postgresql.org/docs/devel/datatype-datetime.html

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Mark all GUC variable as PGDLLIMPORT
Next
From: Christoph Berg
Date:
Subject: Re: Non-decimal integer literals