Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Add min() and max() aggregate functions for xid8 - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject Re: [PATCH] Add min() and max() aggregate functions for xid8
Date
Msg-id 20220209.130444.142792436041672984.horikyota.ntt@gmail.com
Whole thread Raw
In response to Re: [PATCH] Add min() and max() aggregate functions for xid8  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: [PATCH] Add min() and max() aggregate functions for xid8  (Fujii Masao <masao.fujii@oss.nttdata.com>)
List pgsql-hackers
Tree view 
At Wed, 09 Feb 2022 12:04:51 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in 
> At Wed, 9 Feb 2022 11:01:57 +0900, Fujii Masao <masao.fujii@oss.nttdata.com> wrote in 
> > Agreed. So barring any objection, I will commit that patch.
> 
> Sorry for being late, but I don't like the function names.
> 
> +xid8_larger(PG_FUNCTION_ARGS)
> +xid8_smaller(PG_FUNCTION_ARGS)
> 
> Aren't they named like xid8gt and xid8lt conventionally?  At least the
> name lacks a mention to equality.

Ah, sorry. the function returns larger/smaller one from the
parameters. Sorry for the noise.

regardes.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: make MaxBackends available in _PG_init
Next
From: Dilip Kumar
Date:
Subject: Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints