Re: [PATCH] Add min() and max() aggregate functions for xid8 - Mailing list pgsql-hackers

On 2022/02/09 13:04, Kyotaro Horiguchi wrote:
> At Wed, 09 Feb 2022 12:04:51 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in
>> At Wed, 9 Feb 2022 11:01:57 +0900, Fujii Masao <masao.fujii@oss.nttdata.com> wrote in
>>> Agreed. So barring any objection, I will commit that patch.
>>
>> Sorry for being late, but I don't like the function names.
>>
>> +xid8_larger(PG_FUNCTION_ARGS)
>> +xid8_smaller(PG_FUNCTION_ARGS)
>>
>> Aren't they named like xid8gt and xid8lt conventionally?  At least the
>> name lacks a mention to equality.
> 
> Ah, sorry. the function returns larger/smaller one from the
> parameters. Sorry for the noise.

Thanks for the review! I pushed the patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION