Re: Multi-Column List Partitioning - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: Multi-Column List Partitioning
Date
Msg-id 20220114094915.cduei6xvmyrnozep@jrouhaud
Whole thread Raw
In response to Re: Multi-Column List Partitioning  (Nitin Jadhav <nitinjadhavpostgres@gmail.com>)
List pgsql-hackers
Hi,

The cfbot reports some clang warning on the last version of the patchset:

https://cirrus-ci.com/task/6721617647632384

[16:35:24.444] partprune.c:2775:8: error: explicitly assigning value of variable of type 'int' to itself
[-Werror,-Wself-assign]
[16:35:24.444]                         off = off;
[16:35:24.444]

A quick look at the patch seems to indicate that it's harmless dead code that
should be removed, and there are no other failure reported by the cfbot, but I
definitely didn't read the patch carefully so a confirmation (and an updated
patch) would be welcome.

However I see that Amul raised some concerns, so I will change the patch status
to Waiting on Author.  Feel free to switch it back to Needs Review if you think
it's more appropriate.



pgsql-hackers by date:

Previous
From: Julien Rouhaud
Date:
Subject: Re: MultiXact\SLRU buffers configuration
Next
From: Sergey Shinderuk
Date:
Subject: Re: Windows: Wrong error message at connection termination