Re: Isn't wait_for_catchup slightly broken? - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: Isn't wait_for_catchup slightly broken?
Date
Msg-id 20220111062502.obh4gegzcaova5dk@jrouhaud
Whole thread Raw
In response to Isn't wait_for_catchup slightly broken?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, Jan 10, 2022 at 02:31:38PM -0500, Tom Lane wrote:
> 
> So I think we need to fix it to capture the target WAL position
> at the start, as I've done in the attached patch.

+1, it looks sensible to me.

> In principle
> this might make things a bit slower because of the extra
> transaction required, but I don't notice any above-the-noise
> difference on my own workstation.

I'm wondering if the environments where this extra transaction could make
a noticeable difference are also environments where doing that extra
transaction can save some iteration(s), which would be at least as costly.



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Skipping logical replication transactions on subscriber side
Next
From: Gurjeet Singh
Date:
Subject: Patch: Code comments: why some text-handling functions are leakproof