Re: Correct handling of blank/commented lines in PSQL interactive-mode history - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Correct handling of blank/commented lines in PSQL interactive-mode history
Date
Msg-id 20211130215231.GC3167@momjian.us
Whole thread Raw
In response to Re: Correct handling of blank/commented lines in PSQL interactive-mode history  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, Nov 30, 2021 at 04:35:13PM -0500, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > On Mon, Nov 29, 2021 at 11:12:35PM -0500, Tom Lane wrote:
> >> Interesting.  I can probably adjust my MUA to send "text/x-patch",
> >> but I'll have to look around to see where that's determined.
> 
> > I would be interesting to know if "text/x-patch" is better than
> > "text/x-diff" --- I currently use the later.
> 
> I found out that where that is coming from is "file -i", so I'm a
> bit loath to modify it.  Is there any hard documentation as to why
> "text/x-patch" should be preferred?

I thought this was happening from /etc/mime.types:

    text/x-diff                                     diff patch

The file extensions 'diff' and 'patch' trigger mime to use text/x-diff
for its attachments, at least on Debian.  Based on that, I assumed
"text/x-diff" was more standardized than "text/x-patch".

However, it seems file -i also looks at the contents since a file with a
single word in it is not recognized as a diff:

    $ git diff > /rtmp/x.diff
    $ file -i /rtmp/x.diff
    /rtmp/x.diff: text/x-diff; charset=us-ascii
                  -----------
    $ echo test > /rtmp/x.diff
    $ file -i /rtmp/x.diff
    /rtmp/x.diff: text/plain; charset=us-ascii
                  ----------

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Correct handling of blank/commented lines in PSQL interactive-mode history
Next
From: "Bossart, Nathan"
Date:
Subject: Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file