Re: Use simplehash.h instead of dynahash in SMgr - Mailing list pgsql-hackers

From Jaime Casanova
Subject Re: Use simplehash.h instead of dynahash in SMgr
Date
Msg-id 20211004073713.GB6304@ahch-to
Whole thread Raw
In response to Re: Use simplehash.h instead of dynahash in SMgr  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Use simplehash.h instead of dynahash in SMgr  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
On Mon, Sep 27, 2021 at 04:30:25PM +1300, David Rowley wrote:
> On Fri, 24 Sept 2021 at 20:26, Jaime Casanova
> <jcasanov@systemguards.com.ec> wrote:
> > Are you planning to work on this in this CF?
> > This is marked as "Ready for committer" but it doesn't apply anymore.
> 
> I've attached an updated patch. Since this patch is pretty different
> from the one that was marked as ready for committer, I'll move this to
> needs review.
> 
> However, I'm a bit disinclined to go ahead with this patch at all.
> Thomas made it quite clear it's not for the patch, and on discussing
> the patch with Andres, it turned out he does not like the idea either.
> Andres' argument was along the lines of bitmaps being slow.  The hash
> table uses bitmaps to record which items in each segment are in use. I
> don't really agree with him about that, so we'd likely need some more
> comments to help reach a consensus about if we want this or not.
> 
> Maybe Andres has more comments, so I've included him here.
> 

Hi David,

Thanks for the updated patch.

Based on your comments I will mark this patch as withdrawn at midday of 
my monday unless someone objects to that.

-- 
Jaime Casanova
Director de Servicios Profesionales
SystemGuards - Consultores de PostgreSQL



pgsql-hackers by date:

Previous
From: Jaime Casanova
Date:
Subject: Re: Triage on old commitfest entries
Next
From: Alexander Pyhalov
Date:
Subject: Re: Function scan FDW pushdown