On Thu, Sep 30, 2021 at 05:08:24PM +1300, Thomas Munro wrote:
> On Thu, Sep 30, 2021 at 4:49 PM Michael Paquier <michael@paquier.xyz> wrote:
> > fsync_pgdata() is going to manipulate many inodes anyway, because
> > that's a code path designed to do so. If we know that syncfs() is
> > just going to be better, I'd rather just call it by default if
> > available and not add new switches to all the frontend tools in need
> > of flushing the data folder, switches that are not documented in your
> > patch.
>
> If we want this it should be an option, because it flushes out data
> other than the pgdata dir, and it doesn't report errors on old
> kernels.
I ran into bad performance of initdb --sync-only shortly after adding it to my
db migration script, so added initdb --syncfs.
I found that with sufficiently recent coreutils, I can do what's wanted by calling
/bin/sync -f /datadir
Since it's not integrated into initdb, it's necessary to include each
tablespace and wal.
--
Justin
