Re: checking return value from unlink in write_relcache_init_file - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: checking return value from unlink in write_relcache_init_file
Date
Msg-id 202106040055.zkuodwr4lwq7@alvherre.pgsql
Whole thread Raw
In response to Re: checking return value from unlink in write_relcache_init_file  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: checking return value from unlink in write_relcache_init_file  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2021-Jun-03, Tom Lane wrote:

> If the unlink fails, there's only really a problem if the subsequent
> open() fails to overwrite the file --- and that stanza is perfectly
> capable of complaining for itself.  So I think the code is fine and
> there's no need for a separate message about the unlink.  Refusing to
> proceed, as you've done here, is strictly worse than what we have.

It does seem to deserve a comment explaining this.

-- 
Álvaro Herrera       Valdivia, Chile
"Pensar que el espectro que vemos es ilusorio no lo despoja de espanto,
sólo le suma el nuevo terror de la locura" (Perelandra, C.S. Lewis)



pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: RFC: Table access methods and scans
Next
From: Michael Paquier
Date:
Subject: Re: BUG #16079: Question Regarding the BUG #16064