Hi,
On 2021-04-08 01:41:40 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > Independent of this patch, it might be a good idea to have
> > ExecInitParallelPlan() be robust against NULL querystrings. Places like
> > executor_errposition() are certainly trying to be...
>
> FWIW, I think the long-term drift of things is definitely that
> we want to have the querystring available everywhere. Code like
> executor_errposition is from an earlier era before we were trying
> to enforce that. In particular, if the querystring is available in
> the leader and not the workers, then you will get different error
> reporting behavior in parallel query than non-parallel query, which
> is surely a bad thing.
Yea, I think it's a sensible direction - but I think we should put the
line in the sand earlier on / higher up than ExecInitParallelPlan().
Greetings,
Andres Freund