On 2021-Mar-24, Andrew Dunstan wrote:
>
> On 3/24/21 9:23 AM, Andrew Dunstan wrote:
> > On 3/24/21 8:29 AM, Alvaro Herrera wrote:
> > If we're going to do that we probably shouldn't special case any
> > particular settings, but simply take any extra arguments as extra env
> > settings. And if any setting has undef (e.g. PGAPPNAME) we should unset it.
> like this.
Hmm, I like that PGAPPNAME handling has resulted in an overall
simplification. I'm not sure why you prefer to keep PGHOST and PGPORT
handled individually at each callsite however; why not do it like
_install, and add them to the environment always? I doubt there's
anything that requires them *not* to be set; and if there is, it's easy
to make the claim that that's broken and should be fixed.
I'm just saying that cluttering _get_install_env() with those two
settings would result in less clutter overall.
--
Álvaro Herrera Valdivia, Chile
