Re: Snapshot scalability patch issue - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Snapshot scalability patch issue
Date
Msg-id 20210215230840.qohkjkrlq7j35a57@alap3.anarazel.de
Whole thread Raw
In response to Snapshot scalability patch issue  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: Snapshot scalability patch issue
List pgsql-hackers
Hi,

On 2021-02-14 18:42:18 -0800, Peter Geoghegan wrote:
> The call to heap_page_prune() within lazy_scan_heap() passes a bool
> literal ('false') as its fourth argument. But the fourth argument is
> of type TransactionId, not bool. This has been the case since the
> snapshot scalability work performed by commit dc7420c2c92. Surely
> something is amiss here.

Looks like I accidentally swapped the InvalidTransactionId and false
around - luckily they have the same actual bit pattern...

I do wish C could pass arguments by name.

I'll push something once I'm back at my computer...

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Zhihong Yu
Date:
Subject: Re: CREATE INDEX CONCURRENTLY on partitioned index
Next
From: Peter Smith
Date:
Subject: Re: [HACKERS] logical decoding of two-phase transactions