On Fri, Dec 25, 2020 at 10:36:55PM -0500, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Add pg_alterckey utility to change the cluster key
>
> > Modified Files
> > --------------
> > doc/src/sgml/ref/pg_alterkey.sgml | 186 ++++++++++
>
> 1. I wonder why this file is "pg_alterkey.sgml" when the
> program it documents is pg_alterckey.
Oh, mistake then, will fix.
>
> 2. Regardless of name, this file is dead code because you did not
> hook it into the documentation infrastructure.
Wow, another issue.
> 3. The buildfarm says this commit is (still) busted on Win32.
>
> Possibly these commits need more review than you think.
I am fixing those now. It is a sleep() and ifdef-inside-macro problem.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
