Re: automatic analyze: readahead - add "IO read time" log message - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: automatic analyze: readahead - add "IO read time" log message
Date
Msg-id 20201205163926.GB16415@tamriel.snowman.net
Whole thread Raw
In response to Re: automatic analyze: readahead - add "IO read time" log message  (Tomas Vondra <tomas.vondra@enterprisedb.com>)
Responses Re: automatic analyze: readahead - add "IO read time" log message
List pgsql-hackers
Greetings,

* Tomas Vondra (tomas.vondra@enterprisedb.com) wrote:
> Thanks. I'll do some testing/benchmarking once my machines are free, in
> a couple days perhaps. But as I said before, I don't expect this to
> behave very differently from other places that already do prefetching.

Agreed, but would still be nice to see test results beyond just what
I've done.

> FWIW I wonder if this should be tracked separately in the CF app, as
> it's very different from the original "add some logging" patch, which
> makes the CF entry rather misleading.

I've gone ahead and updated the CF entry for this to hopefully make it
clearer for those interested in looking at it.  I'll try to come back to
this in the next CF, ideally we'd at least get someone else to take a
look at the code beyond me. :)  (Obviously, you looked at it some, but
wasn't really clear if you were alright with it or if you felt it needed
more review.)

Thanks!

Stephen

Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Proposed patch for key managment
Next
From: "Bossart, Nathan"
Date:
Subject: Re: A few new options for CHECKPOINT