Re: "as quickly as possible" (was: remove spurious CREATE INDEX CONCURRENTLY wait) - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: "as quickly as possible" (was: remove spurious CREATE INDEX CONCURRENTLY wait)
Date
Msg-id 20201123203124.GA8215@alvherre.pgsql
Whole thread Raw
In response to Re: "as quickly as possible" (was: remove spurious CREATE INDEX CONCURRENTLY wait)  (Michael Paquier <michael@paquier.xyz>)
Responses Re: "as quickly as possible" (was: remove spurious CREATE INDEX CONCURRENTLY wait)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2020-Nov-19, Michael Paquier wrote:

> On Thu, Nov 19, 2020 at 12:13:44PM +0900, Michael Paquier wrote:
> > That still looks useful for debugging, so DEBUG1 sounds fine to me.
> 
> By the way, it strikes me that you could just do nothing as long as
> (log_min_messages > DEBUG1), so you could encapsulate most of the
> logic that plays with the lock tag using that.

Good idea, done.

I also noticed that if we're going to accept a race (which BTW already
exists) we may as well simplify the code about it.

I think the attached is the final form of this.

Attachment

pgsql-hackers by date:

Previous
From: Anastasia Lubennikova
Date:
Subject: Re: DROP relation IF EXISTS Docs and Tests - Bug Fix
Next
From: David Rowley
Date:
Subject: Re: Keep elog(ERROR) and ereport(ERROR) calls in the cold path