Re: Add important info about ANALYZE after create Functional Index - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Add important info about ANALYZE after create Functional Index
Date
Msg-id 20201101002344.GA3000@paquier.xyz
Whole thread Raw
In response to Re: Add important info about ANALYZE after create Functional Index  (Fabrízio de Royes Mello <fabriziomello@gmail.com>)
Responses Re: Add important info about ANALYZE after create Functional Index  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Sat, Oct 31, 2020 at 07:56:33PM -0300, Fabrízio de Royes Mello wrote:
> Even if we won't use it now, IMHO it is more legible to separate this
> responsibility into its own CopyStatistics function as attached.

By doing so, there is no need to include pg_statistic.h in index.c.
Except that, the logic looks fine at quick glance.  In the long-term,
I also think that it would make sense to move both routnes out of
heap.c into a separate pg_statistic.c.  That's material for a separate
patch of course.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Euler Taveira
Date:
Subject: Re: cleanup temporary files after crash
Next
From: Michael Paquier
Date:
Subject: Re: cleanup temporary files after crash