Re: Wrong example in the bloom documentation - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Wrong example in the bloom documentation
Date
Msg-id 20201015235019.GH3797@momjian.us
Whole thread Raw
In response to Re: Wrong example in the bloom documentation  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Wrong example in the bloom documentation
List pgsql-hackers
On Fri, Oct  9, 2020 at 11:08:32AM -0400, Bruce Momjian wrote:
> On Fri, Oct  9, 2020 at 05:44:57AM +0000, Daniel Westermann (DWE) wrote:
> > Hi Bruce, Tom,
> > 
> > On Thu, Oct  8, 2020 at 03:43:32PM -0400, Tom Lane wrote:
> > >> "Daniel Westermann (DWE)" <daniel.westermann@dbi-services.com> writes:
> > >> >> I was hoping someone more experienced with this would comment, but
> > >> >> seeing none, I will apply it in a day or two to all supported versions?
> > >> >> Have you tested this output back to 9.5?
> > >> 
> > >> > I hoped that as well. No, I tested down to 9.6 because the change happened in 10.
> > >> 
> > >> The patch assumes that parallel query is enabled, which is not true by
> > >> default before v10, so it should certainly not be applied before v10
> > >> (at least not without significant revisions).
> > 
> > Yes, the behavior change was in 10. Before 10 the example is fine, I would not apply that to any prior version,
otherwisethe whole example needs to be rewritten.
 
> 
> Agreed.

This is not applying to PG 12 or earlier because the patch mentions JIT,
which was only mentioned in the PG bloom docs in PG 13+.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee




pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pg_upgrade: fail early if a tablespace dir already exists for new cluster version
Next
From: Michael Paquier
Date:
Subject: Re: Some remaining htonl() and ntohl() calls in the code