Postgres Pro
Downloads
Home   >   mailing lists

Re: tab completion of IMPORT FOREIGN SCHEMA - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: tab completion of IMPORT FOREIGN SCHEMA
Date
Msg-id 20200915055640.GO2183@paquier.xyz
Whole thread Raw
In response to Re: tab completion of IMPORT FOREIGN SCHEMA  (Michael Paquier <michael@paquier.xyz>)
Responses Re: tab completion of IMPORT FOREIGN SCHEMA  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
On Mon, Aug 17, 2020 at 02:15:34PM +0900, Michael Paquier wrote:
> Sounds fine to me as well.  The LIMIT TO and EXCEPT clauses are
> optional, so using TailMatches() looks fine.
>
> +   else if (TailMatches("FROM", "SERVER", MatchAny, "INTO", MatchAny))
> +       COMPLETE_WITH("OPTIONS")
> Shouldn't you complete with "OPTIONS (" here?
>
> It would be good to complete with "FROM SERVER" after specifying
> EXCEPT or LIMIT TO, you can just use "(*)" to include the list of
> tables in the list of elements checked.

I have complete the patch with those parts as per the attached.  If
there are any objections or extra opinions, please feel free.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Allow ERROR from heap_prepare_freeze_tuple to be downgraded to WARNING
Next
From: Jeff Davis
Date:
Subject: Re: logtape.c stats don't account for unused "prefetched" block numbers