Re: Reloptions for table access methods - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Reloptions for table access methods
Date
Msg-id 20200901162008.GA12330@alvherre.pgsql
Whole thread Raw
In response to Reloptions for table access methods  (Jeff Davis <pgsql@j-davis.com>)
Responses Re: Reloptions for table access methods  (Jeff Davis <pgsql@j-davis.com>)
List pgsql-hackers
On 2020-Aug-31, Jeff Davis wrote:

> fillRelOptions() validates when filling in a struct to make sure there
> aren't "leftover" options. It does this using a hard-coded parsing
> table that is not extensible.

Hmm, I think that if we're going to do this, we should do it for all
AMs, not just table AMs, since surely index AMs also want extensible
reloptions; and I think that makes the 'validate' mechanism dead code
and so we should remove it.

I think this means that you can have tables with mistyped options, and
you'd not get an error message about them.  Is that right?  Is that what
we want?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: Kerberos support broken on MSVC builds for Windows x64?
Next
From: Stephen Frost
Date:
Subject: Re: Kerberos support broken on MSVC builds for Windows x64?