Re: [PATCH] Fix Uninitialized scalar variable (UNINIT) (src/backend/access/heap/heapam_handler.c) - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCH] Fix Uninitialized scalar variable (UNINIT) (src/backend/access/heap/heapam_handler.c)
Date
Msg-id 20200825231808.GA30348@alvherre.pgsql
Whole thread Raw
In response to Re: [PATCH] Fix Uninitialized scalar variable (UNINIT) (src/backend/access/heap/heapam_handler.c)  (Ranier Vilela <ranier.vf@gmail.com>)
List pgsql-hackers
On 2020-Aug-25, Ranier Vilela wrote:

> 1. Even heap_get_root_tuples at line 1347, be called.
> Does it fill all roots_offsets?

Yes -- read the comments there.

> 2. hscan->rs_cbuf is constant?
> if (hscan->rs_cblock != root_blkno)

It is the buffer that contains the given block.  Those two things move
in unison.  See heapgettup and heapgettup_pagemode.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Ranier Vilela
Date:
Subject: Re: [PATCH] Fix Uninitialized scalar variable (UNINIT) (src/backend/access/heap/heapam_handler.c)
Next
From: Alvaro Herrera
Date:
Subject: Re: [PATCH] Fix Uninitialized scalar variable (UNINIT) (src/backend/access/heap/heapam_handler.c)