Re: please update ps display for recovery checkpoint - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: please update ps display for recovery checkpoint
Date
Msg-id 20200820080905.GA10353@paquier.xyz
Whole thread Raw
In response to RE: please update ps display for recovery checkpoint  ("k.jamison@fujitsu.com" <k.jamison@fujitsu.com>)
Responses Re: please update ps display for recovery checkpoint  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Wed, Aug 19, 2020 at 12:20:50AM +0000, k.jamison@fujitsu.com wrote:
> On Wednesday, August 19, 2020 7:53 AM (GMT+9), Justin Pryzby wrote:
>> During crash recovery, the server writes this to log:
>> Please change to say "recovery checkpoint" or similar, as I mentioned here.
>> https://www.postgresql.org/message-id/20200118201111.GP26045@telsasoft.c
>> om
>
> Yes, I agree that it is helpful to tell users about that.

That could be helpful.  Wouldn't it be better to use "end-of-recovery
checkpoint" instead?  That's the common wording in the code comments.

I don't see the point of patch 0002.  In the same paragraph, we
already know that this applies to any checkpoints.

> About 0003 patch, there are similar phrases in bgwriter_flush_after and
> backend_flush_after. Should those be updated too?

Yep, makes sense.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: [PG13] Planning (time + buffers) data structure in explain plan (format text)
Next
From: Dilip Kumar
Date:
Subject: Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions