Postgres Pro
Downloads
Home   >   mailing lists

Re: min_safe_lsn column in pg_replication_slots view - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: min_safe_lsn column in pg_replication_slots view
Date
Msg-id 20200710234037.GA24580@alvherre.pgsql
Whole thread Raw
In response to Re: min_safe_lsn column in pg_replication_slots view  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: min_safe_lsn column in pg_replication_slots view  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
On 2020-Jul-09, Alvaro Herrera wrote:

> I think we should define InvalidXLogSegNo to be ~((uint64)0) and add a
> macro to test for that.

That's overkill really.  I just used zero.  Running
contrib/test_decoding under valgrind, this now passes.

I think I'd rather do away with the compare to zero, and initialize to
something else in GetWALAvailability, though.  What we're doing seems
unclean and unclear.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Default setting for enable_hashagg_disk
Next
From: David Rowley
Date:
Subject: Re: Default setting for enable_hashagg_disk