Re: [PATCH] Incremental sort (was: PoC: Partial sort) - Mailing list pgsql-hackers

From Tomas Vondra
Subject Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Date
Msg-id 20200509221945.yxixm2evfukdg4ic@development
Whole thread Raw
In response to Re: [PATCH] Incremental sort (was: PoC: Partial sort)  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
Responses Re: [PATCH] Incremental sort (was: PoC: Partial sort)
List pgsql-hackers
On Sat, May 09, 2020 at 10:50:12PM +0200, Tomas Vondra wrote:
>On Sat, May 09, 2020 at 03:18:36PM -0500, Justin Pryzby wrote:
>>Checking if it's possible to address this Opened Item before 13b1.
>>
>>https://wiki.postgresql.org/wiki/PostgreSQL_13_Open_Items
>>consistency of explain output: two spaces, equals vs colons, semicolons (incremental sort)
>>
>
>Yes. Now that the other items related to incremental sort are fixed,
>this is next on my TODO.
>

OK, so aside from the typo/comment fixes, the proposed changes to the
explain format are:

  - two spaces to separate groups of related values
  - use colons rather than equals for fields
  - don't use semicolons
  - split full-groups and prefix-groups to separate lines

I'm generally OK with most of this - I'd probably keep the single-line
format, but I don't feel very strongly about that and if others think
using two lines is better ...

Barring objections I'll get this polished and pushed soon-ish (say,
early next week).


regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Ranier Vilela
Date:
Subject: Re: [PATCH] Fix division by zero (explain.c)
Next
From: Tom Lane
Date:
Subject: Re: Add -Wold-style-definition to CFLAGS?