Re: doc review for v13 - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: doc review for v13
Date
Msg-id 20200410062902.GX1606@paquier.xyz
Whole thread Raw
In response to Re: doc review for v13  (Justin Pryzby <pryzby@telsasoft.com>)
Responses Re: doc review for v13
List pgsql-hackers
On Thu, Apr 09, 2020 at 10:01:51PM -0500, Justin Pryzby wrote:
> On Fri, Apr 10, 2020 at 11:27:46AM +0900, Michael Paquier wrote:
>>  required pages to remove both downlink and rightlink are already  locked.  That
>> -evades potential right to left page locking order, which could deadlock with
>> +avoid potential right to left page locking order, which could deadlock with
>> Not sure which one is better, but the new change is grammatically
>> incorrect.
>
> "Evades" usually means to act to avoid detection by the government.  Like tax
> evasion.

This change is from Alexander Korotkov as of 32ca32d, so I am adding
him in CC to get his opinion.

>>        <varname>auto_explain.log_settings</varname> controls whether information
>> -      about modified configuration options are printed when execution plan is logged.
>> -      Only options affecting query planning with value different from the built-in
>> +      about modified configuration options is printed when an execution plan is logged.
>> +      Only those options which affect query planning and whose value differs from its built-in
>> Depends on how you read the sentence, but here is seemt to me that
>> "statistics" is the correct subject, no?
>
> Statistics ?

Oops.  I may have messed up with a different part of the patch set.
Your suggestion is right as the subject is "information" here.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: WAL usage calculation patch
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Function to track shmem reinit time