On Fri, Apr 10, 2020 at 11:27:46AM +0900, Michael Paquier wrote:
> On Wed, Apr 08, 2020 at 11:56:53AM -0500, Justin Pryzby wrote:
> > I previously mailed separately about a few individual patches, some of which
> > have separate, ongoing discussion and aren't included here (incr sort, parallel
> > vacuum).
>
> I have gone through your changes, and committed what looked like the
> most obvious mistakes in my view. Please see below for more
> comments.
Thanks - rebased for cfbot and continued review.
> required pages to remove both downlink and rightlink are already locked. That
> -evades potential right to left page locking order, which could deadlock with
> +avoid potential right to left page locking order, which could deadlock with
> Not sure which one is better, but the new change is grammatically
> incorrect.
Thanks for noticing
"Evades" usually means to act to avoid detection by the government. Like tax
evasion.
> <varname>auto_explain.log_settings</varname> controls whether information
> - about modified configuration options are printed when execution plan is logged.
> - Only options affecting query planning with value different from the built-in
> + about modified configuration options is printed when an execution plan is logged.
> + Only those options which affect query planning and whose value differs from its built-in
> Depends on how you read the sentence, but here is seemt to me that
> "statistics" is the correct subject, no?
Statistics ?
> <literal>_tz</literal> suffix. These functions have been implemented to
> - support comparison of date/time values that involves implicit
> + support comparison of date/time values that involve implicit
> The subject is "comparison" here, no?
You're right.
--
Justin
