Re: control max length of parameter values logged - Mailing list pgsql-hackers

From Justin Pryzby
Subject Re: control max length of parameter values logged
Date
Msg-id 20200401093142.GN14618@telsasoft.com
Whole thread Raw
In response to Re: control max length of parameter values logged  (Alexey Bashtanov <bashtanov@imap.cc>)
Responses Re: control max length of parameter values logged
List pgsql-hackers
On Wed, Apr 01, 2020 at 10:10:55AM +0100, Alexey Bashtanov wrote:
> Hi,
> > > +        If greater than zero, bind parameter values reported in non-error
> > > +        statement-logging messages are trimmed to no more than this many bytes.
> > Can I suggest to say:
> > 
> > "Limit bind parameter values reported by non-error statement-logging messages
> > to this many bytes". Or,
> > 
> > "The maximum length of bind parameter values to log with non-error
> > statement-logging messages".
> Okay I'll rephrase.
> > Could you make zero a normal value and -1 the "special" value to disable
> > trimming ?
> > 
> > Setting to zero will avoid displaying parameters at all, setting to -1 wil
> > display values in full.
> I can, but then for the sake of consistency I'll have to do the same for
> log_parameter_max_length.
> Then we'll end up with two ways to enable/disable parameter logging on
> error:
> using the primary boolean setting and setting length to 0.
> One of them will require superuser privileges, the other one won't.

I guess you're referring to log_parameters_on_error.
Does it have to be SUSET ?

Or maybe log_parameters_on_error doesn't need to exist at all, and setting
log_parameter_max_length=0 can be used to disable parameter logging.

I showed up late to this thread, so let's see what others think.

-- 
Justin



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Planning counters in pg_stat_statements (using pgss_store)
Next
From: Fujii Masao
Date:
Subject: Re: recovery_target_action=pause with confusing hint