On Wed, Mar 25, 2020 at 11:12:05AM +0900, Artur Zakirov wrote:
> Hello David,
>
> On 3/25/2020 2:08 AM, David Steele wrote:
> > On 12/17/19 3:10 AM, Arthur Zakirov wrote:
> > >
> > > I attached new version of the patch. It still uses
> > > pg_identify_object(), I'm not sure about other ways to build
> > > identities yet.
> >
> > This patch applies and builds but fails regression tests on Linux and
> > Windows:
> > https://travis-ci.org/postgresql-cfbot/postgresql/builds/666134656
> > https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.85292
>
> Regression tests fail because cfbot applies
> "test_rename_catalog_objects.patch". Regression tests pass without it.
>
> This patch shouldn't be applied by cfbot. I'm not sure how to do this. But
> maybe it is possible to use different extension name for the test patch, not
> ".patch".
Yes, see Tom's message here:
https://www.postgresql.org/message-id/14255.1536781029%40sss.pgh.pa.us
I don't know what extensions cfbot looks for; in that case I didn't have a file
extension at all.
--
Justin
