Re: Refactor compile-time assertion checks for C/C++ - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Refactor compile-time assertion checks for C/C++
Date
Msg-id 20200313115033.GA183471@paquier.xyz
Whole thread Raw
In response to Re: Refactor compile-time assertion checks for C/C++  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Refactor compile-time assertion checks for C/C++  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Mar 13, 2020 at 03:12:34PM +0900, Michael Paquier wrote:
> On Thu, Mar 12, 2020 at 09:43:54AM -0400, Tom Lane wrote:
>> I don't feel a need to expend a whole lot of sweat there.  The existing
>> text is fine, it just bugged me that the code deals with three cases
>> while the comment block only acknowledged two.  So I'd just go with
>> what you have in v3.
>
> Thanks, Tom.  I have committed v3 then.

Hmm.  v3 actually broke the C++ fallback of StaticAssertExpr() and
StaticAssertStmt() (v1 did not), a simple fix being something like
the attached.

The buildfarm does not really care about that, but it could for
example by using the only c++ code compiled in the tree in
src/backend/jit/?  That also means that only builds using --with-llvm
with a compiler old enough would trigger that stuff.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Isaac Morland
Date:
Subject: Re: truncating timestamps on arbitrary intervals
Next
From: Justin Pryzby
Date:
Subject: Re: Berserk Autovacuum (let's save next Mandrill)