Re: [Patch] pg_rewind: options to use restore_command fromrecovery.conf or command line - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [Patch] pg_rewind: options to use restore_command fromrecovery.conf or command line
Date
Msg-id 20200313001837.GC1739@paquier.xyz
Whole thread Raw
In response to Re: [Patch] pg_rewind: options to use restore_command fromrecovery.conf or command line  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: [Patch] pg_rewind: options to use restore_command fromrecovery.conf or command line  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
List pgsql-hackers
On Thu, Mar 12, 2020 at 12:50:17PM -0300, Alvaro Herrera wrote:
> Thanks, looks good.  I don't think we *need* the MAXPGPATH restriction
> really -- I was thinking in a StringInfo kind of approach where you just
> append the stuff you need without having to think about the buffer
> length.

Oh, OK.  I missed your point then.  No problem with that by doing it
as the attached.  There is one small trick because of
make_native_path() though.

> Aha, good.  I would still put the new "archive.c" entry on its own line,
> and just keep the other two lines unchanged.  (That preserves the
> perhaps non-obvious property that all entries that start with the same
> letter are in the same line.)

No issues with that either.  Are you fine with the updated version
attached for 0001?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Next
From: Laurenz Albe
Date:
Subject: Re: Berserk Autovacuum (let's save next Mandrill)