Postgres Pro
Downloads
Home   >   mailing lists

Re: Minor improvement to partition_bounds_copy() - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: Minor improvement to partition_bounds_copy()
Date
Msg-id 20200220135229.GA31174@nol
Whole thread Raw
In response to Re: Minor improvement to partition_bounds_copy()  (Amit Langote <amitlangote09@gmail.com>)
Responses Re: Minor improvement to partition_bounds_copy()
List pgsql-hackers
Tree view 
On Thu, Feb 20, 2020 at 09:38:26PM +0900, Amit Langote wrote:
> Fujita-san,
>
> On Thu, Feb 20, 2020 at 8:36 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> > partition_bounds_copy() sets the hash_part and natts variable in each
> > iteration of a loop to copy the datums in the datums array, which
> > would not be efficient.  Attached is small patch for avoiding that.
>
> That looks good to me.

Looks good to me too!

pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: [Patch] Make pg_checksums skip foreign tablespace directories
Next
From: Tom Lane
Date:
Subject: Re: allow running parts of src/tools/msvc/ under not Windows