Postgres Pro
Downloads
Home   >   mailing lists

Re: Add FOREIGN to ALTER TABLE in pg_dump - Mailing list pgsql-hackers

From Tomas Vondra
Subject Re: Add FOREIGN to ALTER TABLE in pg_dump
Date
Msg-id 20200111015253.q6q6h4rpp37qitiv@development
Whole thread Raw
In response to Re: Add FOREIGN to ALTER TABLE in pg_dump  (Luis Carril <luis.carril@swarm64.com>)
Responses Re: Add FOREIGN to ALTER TABLE in pg_dump  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Tree view 
Hi,

On Thu, Sep 26, 2019 at 01:47:28PM +0000, Luis Carril wrote:
>
>I don't disagree with adding FOREIGN, though.
>
>Your patch is failing the pg_dump TAP tests.  Please use
>configure --enable-tap-tests, fix the problems, then resubmit.
>
>Fixed, I've attached a new version.
>

This seems like a fairly small and non-controversial patch (I agree with
Alvaro that having the optional FOREIGN seems won't hurt). So barring
objections I'll polish it a bit and push sometime next week.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Amcheck: do rightlink verification with lock coupling
Next
From: Tomas Vondra
Date:
Subject: Re: How to retain lesser paths at add_path()?